[Webkit-unassigned] [Bug 40775] Table Cell Layering

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 11:41:02 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40775





--- Comment #7 from Fady Samuel <fsamuel at chromium.org>  2010-06-21 11:41:03 PST ---
(In reply to comment #6)
> I can't tell whether the pixel results are passing or failing from looking at just the test and associated test.  Please make it clearer from the test whether it is passing or not (preferably without having to read any text).  A typical pattern with repaint tests is to arrange the test so that a passing result shows only green and repaint bugs are caught by showing some regions as red.  Also, I would really like to see many more simple tests in addition to more complex tests.  When something breaks down the road it should be as easy as possible to tell exactly where the problem is by looking at which tests break.
> 
> The ChangeLog entries have garbage in them.
> 
> I see you've made some changes just to fix style issues.  The logic changes will be easier to review if those style-only changes are split into their own patch.

James, I'll try to simplify the tests. As for other tests, should they all be tests that show WebKit failing right now, or can I add some simple tests that output correctly?

I will fix the changelog and get rid of style fixes in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list