[Webkit-unassigned] [Bug 33004] NetworkStateNotifierWin.cpp doesn't work always

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33004





--- Comment #13 from Adam Roben (aroben) <aroben at apple.com>  2010-06-21 09:15:29 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > It seems like the real fix here is to call NotifyAddrChange again after we
> > receive a notification. Why can't we just add another call to
> > NotifyAddrChange/RegisterWaitForSingleObject inside addressChanged()?
> To register again you must unregister first. This can only be done outside of the callback, because UnregisterWait will return ERROR_IO_PENDING otherwise.
> Maybe there is a working solution with RegisterWaitForSingleObject, but i didn't tried it very hard, because RegisterWaitForSingleObject isn't available on WinCE anyway.

It looks like we don't actually need to call RegisterWaitForSingleObject. Unless you specify WT_EXECUTEONLYONCE, RegisterWaitForSingleObject will continue waiting and calling your callback every time the object is signalled (until UnregisterWait is called). So all we need to do is call NotifyAddrChanged again every time our callback is called.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.