[Webkit-unassigned] [Bug 40792] Script to list duplicated files, and dedupe some chromium-specific LayoutTests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40792





--- Comment #11 from Marcus Bulach <bulach at chromium.org>  2010-06-21 06:37:46 PST ---
thanks Adam and Victor!

the latest patch addresses all your comments so far:
* log instead of print
* moved to WebKitTools/Scripts
* using Executive instead of os.system
* added tests for both scripts

another look please?

(In reply to comment #6)
> (From update of attachment 59093 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/dedupe_chromium_webkit_tests.py:57
>  +  
> remove the empty line to be consistent with rest of the documentation style?
> 
> WebKitTools/Scripts/webkitpy/layout_tests/dedupe_chromium_webkit_tests.py:72
>  +          print 'Running: ' + cmd
> "_log" instead of "print"? same for other "print".

(In reply to comment #9)
> That will also help you with testing because you can mock out the executive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.