[Webkit-unassigned] [Bug 17896] Inspector console should autocomplete the id's in the document when completing document.getElementById

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17896





--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-06-21 05:16:08 PST ---
(From update of attachment 59228)
WebCore/inspector/front-end/ConsoleView.js:353
 +      _getCurrentFunctionName: function(text)
No 'get' prefix in WebKit?

WebCore/inspector/front-end/InjectedScript.js:177
 +      var elems = document.querySelectorAll("[id]");
You are only querying current document, not touching iframes. Imagine the code is frames[0].document.getElementById(...

WebCore/inspector/front-end/InjectedScript.js:190
 +      var elems = document.getElementsByTagName("*");
Same here, this all needs to be done in native code as I've done it to the performSearch.

WebCore/inspector/front-end/InjectedScript.js:235
 +  InjectedScript._generatedCachedQueryObjects = [];
We try to get rid of these...

WebCore/inspector/front-end/InjectedScript.js:380
 +          case "getElementById":
Now this is heuristics. How hard would it be to test whether this function is defined on the document object?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.