[Webkit-unassigned] [Bug 17896] Inspector console should autocomplete the id's in the document when completing document.getElementById

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 20 22:18:05 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=17896





--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2010-06-20 22:18:05 PST ---
Created an attachment (id=59226)
 --> (https://bugs.webkit.org/attachment.cgi?id=59226)
[PATCH] Work in Progress

Feel free to review, but I won't be satisfied with this until I can automatically provide
a closing ")" in the completion. It appears that the ")" triggers a new completion
because ")" is a special character.

This patch provides simple caching. After a list is fetched, a timer is started to clear
all lists after 30 seconds. I could change to timestamps, or cache indefinitely. Any
preferences?

@Pavel. I make use of "window" and "document" directly in this patch. What
should I be worried about? I recently found out document could be destroyed
if the frame navigates, and access to it will cause a crash. =/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list