[Webkit-unassigned] [Bug 40891] Python Tests Fail after r61508

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 20 14:14:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40891


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #5 from Csaba Osztrogonac <ossy at webkit.org>  2010-06-20 14:14:06 PST ---
I think you shouldn't modify the order of 
the bots, because same order in python file 
as on the buildbot master is more readable.

I prefer a patch like this:

diff --git a/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py b/WebKitTools/Scripts/webkitpy/common/net/buildbot_uni
index 5384321..2742040 100644
--- a/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py
@@ -275,6 +275,9 @@ class BuildBotTest(unittest.TestCase):
             {'name': u'Chromium Linux Release', },
             {'name': u'Chromium Mac Release', },
             {'name': u'Chromium Win Release', },
+            {'name': u'Chromium Linux Release (Tests)', },
+            {'name': u'Chromium Mac Release (Tests)', },
+            {'name': u'Chromium Win Release (Tests)', },
             {'name': u'New run-webkit-tests', },
         ]
         name_regexps = [
@@ -285,7 +288,7 @@ class BuildBotTest(unittest.TestCase):
             "Windows.*Build",
             "GTK",
             "Qt",
-            "Chromium",
+            "Chromium.*Release$",
         ]
         expected_builders = [
             {'name': u'Tiger Intel Release', },

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list