[Webkit-unassigned] [Bug 39026] Recognize async attribute on script tags
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 20 12:01:36 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=39026
--- Comment #24 from Tony Gentilcore <tonyg at chromium.org> 2010-06-20 12:01:36 PST ---
(In reply to comment #23)
> (From update of attachment 59198 [details])
> WebCore/dom/ScriptElement.cpp:312
> + return !m_scriptElement->sourceAttributeValue().isEmpty() && m_scriptElement->asyncAttributeValue();
> I suspect that AtomicString has a bool operator, which probably uses isEmpty() under the covers, so you could probably just write this as "m_scriptElement->sourceAttributeValue()"
The ! operator checks isNull() rather than isEmpty().
>
> WebCore/html/HTMLScriptElement.cpp:159
> + setAttribute(asyncAttr, async ? "" : 0);
> The two sides of the ternary are different types. Intentional?
>
This was just copied from setDefer(). Should I update them both to something else?
> WebKitTools/WinLauncher/WinLauncher.vcproj:215
> + AdditionalDependencies="comctl32.lib shlwapi.lib user32.lib ole32.lib oleaut32.lib WebKitGUID$(WebKitConfigSuffix).lib WebKit$(WebKitDLLConfigSuffix).lib"
> Confused by the project changes?
Sorry for the noise. That was a stray diff that accidentally crept in during my sync. It is removed in the latest patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list