[Webkit-unassigned] [Bug 40876] [EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40876


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-06-19 01:57:08 PST ---
Attachment 59181 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:54:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:55:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:92:  Declaration has space between type name and * in Ecore_Evas *ee  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:92:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:95:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:95:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:102:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:109:  Declaration has space between type name and * in Ecore_Evas *ee  [whitespace/declaration] [3]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:109:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:112:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:112:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 11 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.