[Webkit-unassigned] [Bug 17374] Inspector should support tab completion while editing CSS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17374





--- Comment #39 from Nikita Vasilyev <me at elv1s.ru>  2010-06-19 01:50:28 PST ---
(In reply to comment #38)
> (From update of attachment 59166 [details])
> > diff --git a/WebCore/inspector/front-end/CSS.js b/WebCore/inspector/front-end/CSS.js
> 
> I still don't like this file being called CSS.js. Its purpose
> is more about autocompletion. I still like "Completion.js"
> or something along those lines.

This file provides WebInspector.CSS, so I called it CSS.js. It's about CSS completions, not JS completions or something else.


> > +Array.convert = function convert(list)
> > +{
> > +    // Cast array-like object to an array.
> > +    return Array.prototype.slice.call(list);
> > +}
> > +
> 
> Again, I think this should be unnamed to prevent an
> extra global reference. I know this helps JSC find the
> function name in debugging, but I don't think its
> that big of a deal in this case. Also, the engine
> should be improved to infer the name. I think v8 does.

It isn't global for me and it shouldn't be global for you too. If it is, it's a bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.