[Webkit-unassigned] [Bug 40767] DOM storage should delete databases when they are empty.

Fri Jun 18 18:19:51 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40767

Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59081|review?                     |review+
               Flag|                            |

--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-06-18 18:19:51 PST ---
(From update of attachment 59081)
Looks good to me....2 double-checking type questions tho...

WebCore/storage/StorageAreaSync.cpp:421
 +          m_database.close();
Are we super extra ultra sure that there's no way the database can be used after it's closed?  I almost wondr if we should make it an OwnPtr and null it out here so that if we do try to use it later we crash.

WebCore/storage/StorageAreaSync.cpp:403
 +      if (!m_database.isOpen())
When can this happen?  Only if it was never opened or something?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.