[Webkit-unassigned] [Bug 40593] Add BlobBuilder.idl to expose BlobBuilder interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40593





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-18 17:45:29 PST ---
(In reply to comment #4)
> (From update of attachment 59045 [details])
> I think you also need to update rebaseline test results for win/qt/gtk/chromium, like platform/qt/fast/dom/Window/window-property-descriptors-expected.txt.

Added them.

> WebCore/ChangeLog:61
>  +          Add BlobBuilder.idl to expose BlobBuilder interface
> Please also mention the link to the BlobBuilder definition in the FileWriter spec in the ChangeLog.

Done.

> Also, I do not see any change to V8 bindings and gyp. Are you planning to add it later? If so, make sure you land both patches at the same time.

Hmm, I added them to this patch.

> WebCore/bindings/js/JSBlobBuilderCustom.cpp:52
>  +              String endings = "";
> I think we can use the default empty string.

Fixed.

> WebCore/html/BlobBuilder.idl:36
>  +          Blob getBlob(in [ConvertUndefinedOrNullToNullString] DOMString contentType);
> Do we need to add Optional here?

Made it Optional (explicitly).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.