[Webkit-unassigned] [Bug 38693] cleanup json_results_generator dependencies so that non-layout-tests can also use it safely

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38693





--- Comment #15 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-18 16:48:20 PST ---
Thanks for reviewing!

(In reply to comment #13)
> (From update of attachment 58105 [details])
> http://wkrietveld.appspot.com/38693/diff/1/2
> File WebKitTools/ChangeLog (right):
> 
> http://wkrietveld.appspot.com/38693/diff/1/2#newcode18
> WebKitTools/ChangeLog:18: * Scripts/webkitpy/test_package/__init__.py: Added.
> I think a better home for these files would be a new directory in "common". For example:
> webkitpy/common/test.

Done.

> http://wkrietveld.appspot.com/38693/diff/1/5
> File WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py (right):
> 
> http://wkrietveld.appspot.com/38693/diff/1/5#newcode46
> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:46: # Note: They need to match with the webkitpy.test_package.test_results.
> I think you can do this in the import statement and avoid duplicating this list. Namely:
> from webkitpy.test_package.test_results import *
> 
> If that doesn't work, I'd rather we just use test_results.PASS instead of PASS in this file.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.