[Webkit-unassigned] [Bug 40854] JSC bindings for Image Resizer API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40854


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59165|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-06-18 16:12:34 PST ---
(From update of attachment 59165)
I'm pretty sure you can create these bindings without any extra code.  If you have trouble, you should ask dumi.

WebCore/ChangeLog:59
 +  2010-06-18  Sterling Swigart  <sswigart at google.com>
You have two ChangeLogs in this patch.

WebCore/bindings/js/JSCustomImageResizerErrorCallback.cpp:47
 +  JSCustomImageResizerErrorCallback::JSCustomImageResizerErrorCallback(JSObject* callback, JSDOMGlobalObject* globalObject)
We should be able to auto-generate these callbacks now.  There are some examples in the database bindings.

WebCore/html/HTMLImageElement.idl:56
 +          [Custom] void webkitGetImage(in DOMString mimeType, in ImageResizerSuccessCallback successCallback, [Optional] in ImageResizerErrorCallback errorCallback, [Optional] in ResizeOptions options)
This shouldn't be custom.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.