[Webkit-unassigned] [Bug 39243] Auto-generate Canvas overloads in JSC

Fri Jun 18 15:48:19 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39243

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56290|review?                     |review-
               Flag|                            |

--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-06-18 15:48:19 PST ---
(From update of attachment 56290)
In general, I think this is great.  However, Darin asked to review each change separately.  Can you break this up into a series of patches:

1) Rebaseline run-bindings-tests to pick up the PERFECT_HASH_SIZE change.  rs=me for landing that.
2) Update the code generator and show the changes in run-bindings-tests output.
3) One patch each for each API you're converting, along with a test that tries calling the API with each number of arguments and showing that the behavior either doesn't change or changes in a way that we want.

Discussion in other bugs has uncovered that WebIDL specs that you should throw exceptions if you get a number of arguments forbidden by the IDL.  It seems this is the behavior we want for new bindings.  Whether we want to adopt that behavior in old bindings is a question that we'll tackle on a case-by-case basis until we uncover a pattern to our decision making.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.