[Webkit-unassigned] [Bug 35350] DumpRenderTree should allow tests with modal dialogs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 18 14:26:33 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=35350
--- Comment #16 from Prasad Tammana <prasadt at chromium.org> 2010-06-18 14:26:32 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Please do (2) for now. We can try something later that has effects outside DRT.
>
> Sounds good to me. The newest patch that I uploaded today implements 2). Please take a look and approve it if looks ok. Once I get the approval, I'll work on getting it committed. Thanks.
Darin - I set the commit-queue:? flag on the last patch I uploaded which implements your recommendation i.e 2). The only differences in the new patch from the previous one that you've reviewed would be:
1) I reverted the change to performSelector in WebChromeClient.mm
2) I added abortModal method to LayoutTestController and invoked it from the two new tests that I added. Files affect by this would be:
a) DumpRenderTree/mac/LayoutTestControllerMac.mm
b) DumpRenderTree/LayoutTestController.cpp
c) DumpRenderTree/LayoutTestController.h
d) LayoutTests/fast/events/resources/modal-dialog.html
e) LayoutTests/fast/harness/resources/modal-dialog.html
If the changes look ok to you, please set commit-queue:+ on the patch. Thanks.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list