[Webkit-unassigned] [Bug 40593] Add BlobBuilder.idl to expose BlobBuilder interface

Fri Jun 18 10:22:45 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40593

Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59045|review?                     |review-
               Flag|                            |

--- Comment #4 from Jian Li <jianli at chromium.org>  2010-06-18 10:22:45 PST ---
(From update of attachment 59045)
I think you also need to update rebaseline test results for win/qt/gtk/chromium, like platform/qt/fast/dom/Window/window-property-descriptors-expected.txt.

WebCore/ChangeLog:61
 +          Add BlobBuilder.idl to expose BlobBuilder interface
Please also mention the link to the BlobBuilder definition in the FileWriter spec in the ChangeLog.

Also, I do not see any change to V8 bindings and gyp. Are you planning to add it later? If so, make sure you land both patches at the same time.

WebCore/bindings/js/JSBlobBuilderCustom.cpp:52
 +              String endings = "";
I think we can use the default empty string.

WebCore/html/BlobBuilder.idl:36
 +          Blob getBlob(in [ConvertUndefinedOrNullToNullString] DOMString contentType);
Do we need to add Optional here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.