[Webkit-unassigned] [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40540


Daniel Cheng <dcheng at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58937|0                           |1
        is obsolete|                            |
  Attachment #59101|                            |review?, commit-queue?
               Flag|                            |




--- Comment #43 from Daniel Cheng <dcheng at chromium.org>  2010-06-18 06:14:00 PST ---
Created an attachment (id=59101)
 --> (https://bugs.webkit.org/attachment.cgi?id=59101)
Patch

(In reply to comment #42)
> (From update of attachment 58937 [details])
> WebKit/chromium/public/WebClipboard.h:71
>  +      // FIXME: Make this pure virtual after landing Chrome changes.
> no need.  since this is an interface implemented by chromium, we should make all of
> the methods have default implementations.  that is what we do normally for interfaces
> implemented by the embedder.  so instead of the FIXME, you can just change all methods
> to have defualt implementations :)

Done.

> WebKit/chromium/public/WebDataTransfer.h:39
>  +          ClipboardSource,
> nit: the convention for the API is to put the common name first.  so it should
> be SourceClipboard, SourceSelection, SourceDrag instead.
> 

Done.

> WebKit/chromium/public/WebKitClient.h:90
>  +      virtual WebVector<WebString> getDataTransferTypes(WebDataTransfer::Source) { return WebVector<WebString>(); }
> it seems like it would be better to either put these methods on WebClipboard
> or make WebKitClient have a method that returns the current WebDataTransfer.
> that way we are not just dumping more stuff in WebKitClient.
> 

Done.

> WebKit/chromium/src/ChromiumBridge.cpp:220
>  +      WebKit::WebString resultData;
> no need for WebKit:: prefix in this file.  there is a using decl up top.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.