[Webkit-unassigned] [Bug 40807] [EFL] add support for logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40807





--- Comment #2 from Lucas De Marchi <lucas.demarchi at profusion.mobi>  2010-06-18 05:32:01 PST ---
(From update of attachment 59066)
Patch looks good. I'm not an official reviewer, so I'll give an informal review.

>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>+    char* logv = strtok(logEnv, " ");

I'd prefer a "," separator as QT guys do because:
   1) It's how eina sets log levels with EINA_LOG_LEVELS
   2) It allows to pass log levels without quoting

However, it's just my preference. I'm CCing the author of eina_log to have his opinion on this.


>+
>+    while (logv) {
>+        if (WTFLogChannel* channel = getChannelFromName(String(logv)))
>+            channel->state = WTFLogChannelOn;
>+        logv = strtok(0, " ");
>+    }
>+
>+    // to disable logging notImplemented set the DISABLE_NI_WARNING
>+    // environment variable to 1

Comments start with capital letter and ends with a dot/punctuation mark. (taken from a review I received on #39821).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.