[Webkit-unassigned] [Bug 40770] Add tests for CSS3 Paged Media's page breaks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40770


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58984|review?                     |review-
               Flag|                            |




--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-17 22:09:45 PST ---
(From update of attachment 58984)
LayoutTests/ChangeLog:5
 +          Add tests for CSS3 Paged Media's page breaks. Some tests are expected to fail because some features are not implemented.
Could you write the names of failing tests?

LayoutTests/ChangeLog:5
 +          Add tests for CSS3 Paged Media's page breaks. Some tests are expected to fail because some features are not implemented.
We usually don't write long lines in ChangeLog. Also, it would be better to break line after the bugzilla summary.

LayoutTests/printing/script-tests/page-break-after-avoid.js:6
 +      // block 'page2-1' must move to the next page because it has 'page-break-after:avoid' and 'page2-1' and 'page2-2' cannot be placed in the current page at the same time.
We usually don't write long line comments either. Maybe ~100 characters would be the threshold.

LayoutTests/ChangeLog:21
 +          * printing/page-break-mergin-collapsed-expected.txt: Added.
s/mergin/margin/

It's somewhat difficult to review 10 tests at once. Could you split this patch? We don't need 10 patches. Maybe

1. for orphans and widows (3 tests)
2. for page-break-*avoid (3 tests)
3. for others (4 tests)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.