[Webkit-unassigned] [Bug 38693] cleanup json_results_generator dependencies so that non-layout-tests can also use it safely

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 17:02:38 PDT 2010


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #58105|review?                     |review-
               Flag|                            |

--- Comment #13 from Ojan Vafai <ojan at chromium.org>  2010-06-17 17:02:38 PST ---
(From update of attachment 58105)
Very sorry this took so long to review. Now that I can see it in rietveld it's much easier to see that this is mostly just moving code around. Anyways, r- due to a few minor issues. Otherwise this looks good.
File WebKitTools/ChangeLog (right):

WebKitTools/ChangeLog:18: * Scripts/webkitpy/test_package/__init__.py: Added.
I think a better home for these files would be a new directory in "common". For example:

File WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py (right):

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:46: # Note: They need to match with the webkitpy.test_package.test_results.
I think you can do this in the import statement and avoid duplicating this list. Namely:
from webkitpy.test_package.test_results import *

If that doesn't work, I'd rather we just use test_results.PASS instead of PASS in this file.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list