[Webkit-unassigned] [Bug 40779] [Chromium] Perf regression following landing of HTML5 parser

Thu Jun 17 16:56:27 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40779

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59047|review?                     |review+
               Flag|                            |

--- Comment #11 from Eric Seidel <eric at webkit.org>  2010-06-17 16:56:27 PST ---
(From update of attachment 59047)
WebCore/html/HTML5TreeBuilder.h:86
 +      static bool isScriptingFlagEnabled(Frame* frame);
No need for the argument name.

WebCore/html/HTML5TreeBuilder.cpp:142
 +      if (tagName == styleTag || tagName == iframeTag || tagName == xmpTag || tagName == noembedTag || tagName == noframesTag || (tagName == noscriptTag && isScriptingFlagEnabled(frame)))
Can we wrap this line? :)

Looks good to me.  I'd like Adam to look too to make sure scriptController->canExecuteScripts(NotAboutToExecuteScript) is the right flavor of "can we script now" call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.