[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

Thu Jun 17 14:42:38 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=27551

Kevin Ollivier <kevino at theolliviers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58961|0                           |1
        is obsolete|                            |
  Attachment #59038|                            |review?
               Flag|                            |

--- Comment #38 from Kevin Ollivier <kevino at theolliviers.com>  2010-06-17 14:42:36 PST ---
Created an attachment (id=59038)
 --> (https://bugs.webkit.org/attachment.cgi?id=59038)
Switch to JS_EXPORTED_SYMBOL, various style and port fixes

Now all the JS internal exports are controlled using a single define, JS_EXPORTED_SYMBOL. The rest of the changes from the last patch are all fixes for build and style bot problems. 

To me, most of the remaining style issues look like either false alarms or really issues that should have a separate bug filed. (e.g. the warnings about DEFINE_GLOBAL, are those legit?)

I've made sure the Mac port builds, and addressed the GTK issue I saw on the EWS bot. Hopefully these changes will fix the Win build as well, but if not, how do I get to the actual files that have the compilation errors for the Win EWS bot?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.