[Webkit-unassigned] [Bug 36282] CSS3 "Property is declared twice in rule" test fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36282





--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2010-06-17 11:40:17 PST ---
(In reply to comment #4)
> Created an attachment (id=59022)
 --> (https://bugs.webkit.org/attachment.cgi?id=59022) [details]
> Patch

Some clarification, I had to change the padding handling to discard negative padding earlier, i.e. when parsing instead of only at style selection time. The reason is that the duplicate property filtering should not have the knowledge to discard negative padding.
The filtering could maybe be put in a private method that can be reused, I'll have to look in the similar FIXME spot and another place in CSSMutableStyleDeclration.cpp that seems to do filtering.
I didnt try to make the filtering as fast as possible yet, it seems to me it will always be a bit slower than the current code, otoh I assume duplicate properties are rare.
What I assume may need to be done is adding tests, I have some ideas for that but suggestions are welcome.
The patch does not cause new regressions.
Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.