[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27551


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com




--- Comment #35 from Geoffrey Garen <ggaren at apple.com>  2010-06-17 11:18:08 PST ---
I don't think it's good to have both JS_EXPORT_PRIVATE and JS_EXPORTDATA. It's not immediately clear which you should use where.

JS_EXPORT_PRIVATE is a confusing phrase because, read literally, it's an oxymoron: things that are private are things that are *not* exported.

Maybe standardizing on something like "JS_EXPORTED_SYMBOL" would be better.

If this patch made symbol export work the same on all platforms, so that all you had to do when exporting a symbol was to add JS_EXPORTED_SYMBOL to it, without updating any .exp or .def files, I'd be really excited about it. But as it stands, it's just global clutter and more maintenance work for the core maintainers of JavaScriptCore, with no benefit to them. As a result, I'm inclined to say 'no' to this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.