[Webkit-unassigned] [Bug 40723] Fix paren matching rules for switch/if/while in check-webkit-style script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40723





--- Comment #4 from Sam Magnuson <smagnuson at netflix.com>  2010-06-17 10:37:24 PST ---
(In reply to comment #2)
> (From update of attachment 58908 [details])
> Looks good. Thanks for this patch!
> 
> Please run the style checker for WebCore/*/*.{cpp,h} and examine if there are no false postives.
> 

I shouldn't have been so confident :) I noticed that:

for(int a = 0; a < 10; )

Got broken with my change, I've fixed that in the revised patch.

> WebKitTools/Scripts/webkitpy/style/processors/cpp_unittest.py: 
>  +          self.assert_lint('while (  foo  ) {', 'Should have zero or one spaces inside'
> I think we still want this test. Maybe this case should produce two errors?

This actually will spit out the to messages (one for the space after '(' and one for the space before ')'. I didn't see any other tests that check for two errors, are there anyway?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.