[Webkit-unassigned] [Bug 40718] [Qt] Platform plugin's multi-select does not take OptGroup into account

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40718





--- Comment #3 from Yael <yael.aharon at nokia.com>  2010-06-17 06:54:22 PST ---
(In reply to comment #2)
> (From update of attachment 58953 [details])
> WebKit/qt/examples/platformplugin/WebPlugin.h:56
>  +      virtual bool isMultiple() const { return false; }
> I think this is what the extension was supposed to be used for
> 
This virtual function is for checking if a specific select element is defined as multi or not, while the extension is to check if the plugin supports miltiple dialogs.

> WebKit/qt/examples/platformplugin/WebPlugin.cpp:117
>  +      emit selectItem(idx, m_popup->isMultiple(), false);
> isnt this used for single as well? 
> 
Yes, and when this is used for single select, we should pass false, not true for the second parameter. This is why I added the above virtual function :-)

> WebKit/qt/WebCoreSupport/QtPlatformPlugin.h:51
>  +      SelectData* m_selectData;
> isnt there a way to keep this away from the header?
> 
I am not sure how to do that without introducing a memory leak or a wrapper for this class.
Please keep in mind that the header is internal implementation of the sample plugin, I don't think it is a problem that this is in the header.

> WebCore/dom/SelectElement.cpp:92
>  +  #if ENABLE(NO_LISTBOX_RENDERING)
> We should really turn this into a runtime thing so that it can even consult the plugin to see if it (the plugin) implements multiselection (using the extension)
I don't think there is a use case for supporting a full screen dialog for single select, and not for multi select. In small devices, we always want both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.