[Webkit-unassigned] [Bug 40772] New: Warnings in v8 bindings with possible bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40772

           Summary: Warnings in v8 bindings with possible bug
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: thomasvl at chromium.org


We're trying to turn on -Wextra in for Chromium on the Mac.  All the core Chromium code is now clean, so we're down to a half dozen hits in WebKit and v8.  The v8 hits are (paths are from chromium build):

src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: In static member function 'static v8::Handle<v8::Value> WebCore::V8SQLResultSetRowList::itemCallback(const v8::Arguments&)':
src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:59: warning: comparison of unsigned expression < 0 is always false

Is putting a signed value into an unsigned and then checking for < 0.  Dropping the check would fix the warning, but the sign drop could be an real issue.


src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp: In function 'void _NPN_DeallocateObject(NPObject*)':
src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp:299: warning: comparison of unsigned expression >= 0 is always true

This is an assert for npObject->referenceCount being >= 0, but since referenceCount appears to be an uint32, the assert can probably just be dropped.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.