[Webkit-unassigned] [Bug 40723] Fix paren matching rules for switch/if/while in check-webkit-style script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 23:33:41 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40723


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58908|review?                     |review+
               Flag|                            |




--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-16 23:33:40 PST ---
(From update of attachment 58908)
Looks good. Thanks for this patch!

Please run the style checker for WebCore/*/*.{cpp,h} and examine if there are no false postives.

WebKitTools/Scripts/webkitpy/style/processors/cpp_unittest.py: 
 +          self.assert_lint('while (  foo  ) {', 'Should have zero or one spaces inside'
I think we still want this test. Maybe this case should produce two errors?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list