[Webkit-unassigned] [Bug 40280] <meter> should allow styling for each gauge-level and component

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40280





--- Comment #16 from MORITA Hajime <morrita at google.com>  2010-06-16 23:28:30 PST ---
Hi Kent-san, thank you for reviewing again!
I updated the patch.

> LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:8
>  +      window.setTimeout(function(evt) {
> Need a comment why setTimeou() is used.
> 
> Do you want to confirm the value change updates the element style?
> if so, .offsetWidth may help to force repainting.
Fixed to remove setTimeout() and force repaint by touching style object.

> LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:19
>  +    meter.styled { -webkit-appearance: none; }
> WebKit should reset -webkit-appearance automatically if an element has user-specified style, like <progress>.
> Ideally, if
>   #id1::-webkit-meter-horizonta-bar { background-color: white; }
> is specified, -webkit-appearance for <meter id=id1> should be reset automatically.  
Done. tests are also updated.

> WebCore/rendering/RenderIndicator.cpp:22
>  +  #include "RenderIndicator.h"
> We had better enclose the code with #if ENABLE(PROGRESS_TAG) || ENABLE(METER_TAG)
Done.

> WebCore/rendering/RenderIndicator.h:24
>  +  #if ENABLE(PROGRESS_TAG)
> ditto.
Doe.

> WebCore/rendering/RenderIndicator.h:29
>  +  //class ShadowBlockElement;
> This line should be removed.
Done.

> WebCore/rendering/RenderTheme.h:198
>  +      virtual bool supportsHorizontalMeter() const { return false; }
> supportsHorizontalMeter() should have a ControlPart parameter because a platform might support just one or two of the three indicator appearances.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.