[Webkit-unassigned] [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40540





--- Comment #41 from Daniel Cheng <dcheng at chromium.org>  2010-06-16 21:38:00 PST ---
(In reply to comment #40)
> (In reply to comment #39)
> > Attachment 58937 [details] [details] did not build on chromium:
> > Build output: http://webkit-commit-queue.appspot.com/results/3290268
> 
> So I can only repro this if I don't run update-webkit --chromium first to update the makefiles. As long as I run update-webkit --chromium before building, it works.
> 
> If there are no other objections, can I get a CQ+? If it does end up breaking the Chrome bot, I will roll it out immediately.

I figured out why my patch fails on the Chrome EWS bot. The Chrome EWS bot does not seem to run GYP after it applies a patch. Other patches that have added new files didn't fail because there were no dependencies from other files on the new files. My patch added a dependency on WebDataTransfer.h from WebKitClient.h, which is why the compile fails. The normal build bots should handle this change correctly.

In the long run, it'd be nice to make the cr-linux bot run GYP when it needs to.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.