[Webkit-unassigned] [Bug 40381] [Qt] for debugging purposes I'm contributing back my FPS counter in the AnimationQtBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40381


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58898|review?                     |review-
               Flag|                            |




--- Comment #8 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-16 09:57:18 PST ---
(From update of attachment 58898)
In the future please make style changes not belonging to the patch itself in a separate patch

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:45
 +  #define QT_DEBUG_FPS 1
You really want to summit it with 1 here?


WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1131
 +          if ( newState == Running && oldState == Stopped ) {
wrong style

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1135
 +          } else if ( newState == Stopped && oldState == Running ) {
here as well

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1192
 +      int   m_frames;
here as well

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.