[Webkit-unassigned] [Bug 40712] New: webkit-patch failure-reason crashes at r61139 when using git (because that commit was on a branch)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40712

           Summary: webkit-patch failure-reason crashes at r61139 when
                    using git (because that commit was on a branch)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: eric at webkit.org, abarth at webkit.org


webkit-patch failure-reason crashes at r61139 when using git. Here's the exception you get:

Traceback (most recent call last):
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkit-patch", line 64, in <module>
    main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkit-patch", line 59, in main
    WebKitPatch(__file__).main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 274, in execute
    return self._explain_failures_for_builder(builder, start_revision=int(start_revision))
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 247, in _explain_failures_for_builder
    self._print_blame_information_for_transition(build, last_build_with_results, fixed_results)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 206, in _print_blame_information_for_transition
    commit_info = self.tool.checkout().commit_info_for_revision(revision)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 63, in commit_info_for_revision
    committer_email = self._scm.committer_email_for_revision(revision)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 573, in committer_email_for_revision
    git_commit = self.git_commit_from_svn_revision(revision)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 560, in git_commit_from_svn_revision
    raise ScriptError(message='Failed to find git commit for revision %s, your checkout likely needs an update.' % revision)
webkitpy.common.system.executive.ScriptError: Failed to find git commit for revision 61139, your checkout likely needs an update.

The problem is that r61139 was on a branch that I don't have included in my git repository. Maybe we should just skip over revisions like these?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.