[Webkit-unassigned] [Bug 40675] Web Inspector: native serialization support in the bindings for WebInspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40675





--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2010-06-16 06:45:14 PST ---
(From update of attachment 58890)

WebCore/WebCore.gyp/WebCore.gyp:624
 +              'generator_include_dirs': [
why do you need this?

WebCore/bindings/scripts/CodeGeneratorWI.pm:108
 +   * 1. Redistributions of source code must retain the above copyright
Please fix the license header.

WebCore/bindings/scripts/IDLStructure.pm:83
 +  our $supportedTypes = "((?:unsigned )?(?:int|short|(?:long )?long)|(?:$idlIdNs*))";
revert?

WebCore/inspector/InspectorFrontend2.wii:72
 +  //        void pausedScript(SerializedScriptValue* callFrames);
remove all commented code
WebCore/inspector/TimelineRecordFactory.cpp:53
 +  //    if (ScriptCallStack::stackTrace(5, frontend->scriptState(), stackTrace))
Please uncomment this. Also I don't understand why ScriptState used here is that of the front end.

WebKit/gtk/ChangeLog:5
 +          WebInspector: bugfix.
Change log should be more descriptive.

WebKit/qt/ChangeLog:5
 +          WebInspector: bugfix.
Change log should be more descriptive.

WebCore/CMakeLists.txt:290
 +      inspector/InspectorFrontend2.wii
I really don't like the idea of using .wii extension for idl files just to associate them with another code generator. Is it possible to leave .idl extension for them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.