[Webkit-unassigned] [Bug 40280] <meter> should allow styling for each gauge-level and component

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40280





--- Comment #13 from Kent Tamura <tkent at chromium.org>  2010-06-16 03:26:08 PST ---
(From update of attachment 58853)

LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:8
 +      window.setTimeout(function(evt) {
Need a comment why setTimeou() is used.

Do you want to confirm the value change updates the element style?
if so, .offsetWidth may help to force repainting.
  document.getElementById("target1").offsetWidth;
  document.getElementById("target1").value = 90;
  ...
  document.getElementById("target1").offsetWidth;



LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:19
 +    meter.styled { -webkit-appearance: none; }
WebKit should reset -webkit-appearance automatically if an element has user-specified style, like <progress>.
Ideally, if
  #id1::-webkit-meter-horizonta-bar { background-color: white; }
is specified, -webkit-appearance for <meter id=id1> should be reset automatically.  However, I don't have no idea how to implement it.

WebCore/rendering/RenderIndicator.cpp:22
 +  #include "RenderIndicator.h"
We had better enclose the code with #if ENABLE(PROGRESS_TAG) || ENABLE(METER_TAG)


WebCore/rendering/RenderIndicator.h:24
 +  #if ENABLE(PROGRESS_TAG)
ditto.

WebCore/rendering/RenderIndicator.h:29
 +  //class ShadowBlockElement;
This line should be removed.


WebCore/rendering/RenderTheme.h:198
 +      virtual bool supportsHorizontalMeter() const { return false; }
supportsHorizontalMeter() should have a ControlPart parameter because a platform might support just one or two of the three indicator appearances.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.