[Webkit-unassigned] [Bug 40280] <meter> should allow styling for each gauge-level and component

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 00:47:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40280





--- Comment #11 from MORITA Hajime <morrita at google.com>  2010-06-16 00:47:39 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > > WebCore/rendering/RenderTheme.cpp:236
> > >  +  bool RenderTheme::canPaintControlsFor(RenderObject* renderObject) const
> > > Can we merge this into RenderTheme::isControlStyled()?
> 
> > No, It cannot.
> > But I agree that canPaintControlsFor() is over-generalized.
> > So I removed it and added supportsHorizontalMeter() instead.
> 
> Could you explain the reason why it can't?

- We need a RenderObject to refer the layout result, but isControlStyled() doesn't have it. 
   Because it is called before RenderObjects creation. 
- isControlStyle() requires extra arguments like BorderData which are not available for us.
- RenderTheme::adjustStyle() rewrites RenderStyle::m_appearance based on the result of isControlStyled().
   But we want to preserve the original appearance value always for <meter>.

After all, isControlStyled() is based on the specified style, 
canPaintControlsFor() is based on the layout result.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list