[Webkit-unassigned] [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40327





--- Comment #11 from Alex Milowski <alex at milowski.com>  2010-06-15 23:13:21 PST ---
(In reply to comment #10)
> (From update of attachment 58778 [details])
> > Index: WebCore/ChangeLog
> > ===================================================================
> > --- WebCore/ChangeLog	(revision 61186)
> > +++ WebCore/ChangeLog	(working copy)
> > @@ -1,3 +1,19 @@
> > +2010-06-15  Alex Milowski  <alex at milowski.com>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Fixed a compile error in the paint() methods by making them  use the 
> 
> Extra space after them.

*sigh*   Really?

> 
> > +        new visitedDependentColor() method.
> 
> Please add bug link.

Bug link to what bug? 

> 
> > +
> > +        Fixed a crash in RenderMathMLRoot with the tests where there were 
> > +        bad assumptions about the children in the layout.
> 
> This would be better as a function comment (for RenderMathMLRoot::layout).

No, not really.  There would be no useful comment to add for either of the two
changes that would enhance the understanding of the code relating to the 
current status and the fix for the above code.

Of course, you can always argue for more comments in general in the layout()
method, but not relating to the fix for this crash.

What mark it review+ when you don't like the ChangeLog entry?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.