[Webkit-unassigned] [Bug 40280] <meter> should allow styling for each gauge-level and component

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40280





--- Comment #9 from MORITA Hajime <morrita at google.com>  2010-06-15 22:17:08 PST ---
Hi Kent-san, thank you for reviewing!
I updated the patch.

(In reply to comment #4)
> (From update of attachment 58632 [details])
> LayoutTests/ChangeLog:10
>  +          - Disabled pixel tests for HTMLMeterElement is temporality disabled.
> This sentence looks curious.  Maybe either of "disabled" is not needed?
> typo: temporality -> temporarily
Done (removed).

> 
> 
> LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:13
>  +          window.setTimeout(function(evt) {
> What's the intention of this setTimeout()?
Removed.
On writing it, I'd like to make sure that rendering is done, though I realized that it's useless.

> 
> 
> LayoutTests/platform/qt/Skipped:3289
>  +  fast/dom/HTMLMeterElement/meter-element.html
> Because Qt has ENABLE_METER_TAG, we don't need to skip the test.  we can:
>  - Commit this change
>  - Qt buildbot runs
>  - Pick the Qt test result
>  - Commit it
OK, remove the line from Skipped file.

> 
> 
> WebCore/WebCore.xcodeproj/project.pbxproj:21781
>  +                  A7AA66D611C5ED6A001D8C8C /* RenderIndicator.cpp in Sources */,
> Should be sorted.
Oops. I'll sort it before landing because sorting tend to cause a conflict.

> WebCore/rendering/RenderMeter.cpp:66
>  +      return IntRect(borderLeft() + paddingLeft(), borderTop() + paddingTop(), lround(width() - borderLeft() - paddingLeft() - borderRight() - paddingRight()), height()  - borderTop() - paddingTop() - borderBottom() - paddingBottom());
> We should have a test for this.  e.g.
> meter {
>   border-left-width: 100px;
>   border-right-width: 1px;
> }
> and the meter value is just a half.
Added a test to meter-style.html.

> WebCore/rendering/RenderTheme.cpp:236
>  +  bool RenderTheme::canPaintControlsFor(RenderObject* renderObject) const
> Can we merge this into RenderTheme::isControlStyled()?
No, It cannot.
But I agree that canPaintControlsFor() is over-generalized.
So I removed it and added supportsHorizontalMeter() instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.