[Webkit-unassigned] [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40540


Daniel Cheng <dcheng at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58821|0                           |1
        is obsolete|                            |
  Attachment #58821|review?                     |
               Flag|                            |
  Attachment #58835|                            |review?
               Flag|                            |




--- Comment #21 from Daniel Cheng <dcheng at chromium.org>  2010-06-15 16:31:24 PST ---
Created an attachment (id=58835)
 --> (https://bugs.webkit.org/attachment.cgi?id=58835)
Patch

(In reply to comment #20)
> (In reply to comment #17)
> > > WebKit/chromium/public/WebKitClient.h:90
> > >  +      virtual bool clipboardWriteData(const WebDragData& data) { return false; }
> > > shouldn't this method be declared on WebClipboard instead?  that
> > > interface exists to collect all of the clipboard related callbacks
> > > to the embedder.
> > > 
> > 
> > Why do we go through all that indirection? I find it hard to follow personally:
> > ChromiumBridge->WebKitClient->WebClipboard->WebClipboardImpl->renderer glue, which in the end, just calls an IPC. Is this for the test shell?
> > 
> > Isn't it simpler to just say:
> > ChromiumBridge->WebKitClient->IPC?
> 
> It helps provide some grouping to WebKitClient.  I think it would
> become a giant mess to have everything flattened into a single
> implementation.
> 

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.