[Webkit-unassigned] [Bug 40378] [Qt] When any geometry change happens to a node it will resize the backing cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40378





--- Comment #9 from Sam Magnuson <smagnuson at netflix.com>  2010-06-15 14:17:37 PST ---
(In reply to comment #7)
> (From update of attachment 58806 [details])
> =WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:44
>  +  // #define QT_DEBUG_CACHEDUMP
> This alone accounts for an r-, please remove
> 

It seems convenient to document the define somewhere for turning on debugging - where should that go instead?

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:222
>  +          QSizeF            size;
> We do not do indentation like this; just one space
> 

Ok.

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:316
>  +      if ( QPixmapCache::find(m_backingStore.key, &pixmap) )
> no space before QPixmap and at the end.
> 

I thought I've had such things flagged by check-webkit-style before - but these seemed to slip by...

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:323
>  +          // If the pixmap is not in the cache or the view has grown since the last cache
> missing dot
>

Fixed these.

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:346
>  +                  const QRegion cleanRegion = (QRegion(0, 0, m_size.width(), m_size.height()) &
> the & should be at the next line, consult our style guide, please
>

I don't see that documented anywhere, or flagged by check-webkit-style. Where should I be looking for these details?

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:405
>  +              pixmap.save(QString().sprintf("/tmp/%05d_C.png", recacheCount), "PNG");
> is PNG supposed to be uppercase?
> 

Yes, I believe so:

http://doc.qt.nokia.com/4.6/qimage.html#reading-and-writing-image-files

//Sam

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.