[Webkit-unassigned] [Bug 40598] [Qt] QtWebkit Crashes on loading CelticKane Standard tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40598





--- Comment #3 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2010-06-15 11:09:34 PST ---
(In reply to comment #2)
> I don't know if the inline capacity was added here based on actual measurements, but this change may negatively affect performance.

We've done some benchmarking (test_page.html):

linux
Vector on stack, buffer on stack: 43 - 44 ms
Vector on heap, buffer on heap: 44 - 45 ms
Vector on stack, buffer on heap: 43.5 - 44 ms

Windows XP
Vector on stack, buffer on stack: 83 - 84 ms
Vector on heap, buffer on heap: 94 - 95 ms
Vector on stack, buffer on heap: 88 - 89 ms

Yes, it affects performance, but it seems the difference is not big.
This code could be called recursively and 1k buffer on stack is not right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.