[Webkit-unassigned] [Bug 40254] [Qt] FrameLoaderClientQt.cpp has coding-style errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 15 06:26:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40254


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Other                       |All
         OS/Version|Mac OS X 10.5               |All
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |QtTriaged
           Severity|Normal                      |Trivial
           Priority|P2                          |P5
                 CC|                            |jedrzej.nowacki at nokia.com
     Ever Confirmed|0                           |1




--- Comment #3 from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>  2010-06-15 06:26:25 PST ---
Personally I think that change should be avoided, you are touching most of the lines, it means that when somebody will call git blame he will find your patch on top. It is not end of the world, but it is annoying.

R- for incorect comments. A comment in the webkit should be a full english phrase ended with '.'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list