[Webkit-unassigned] [Bug 36128] [Gtk] nameFromChildren is obsolete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36128


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58479|0                           |1
        is obsolete|                            |
  Attachment #58479|review?                     |
               Flag|                            |
  Attachment #58770|                            |review?
               Flag|                            |




--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2010-06-15 04:57:54 PST ---
Created an attachment (id=58770)
 --> (https://bugs.webkit.org/attachment.cgi?id=58770)
combined patch (code+test) to fix this bug

(In reply to comment #11)
> [...]
> My first priority for tomorrow morning is to work on this bug and try a 
> suggestion coming from Martin Robinson that could help a lot to get a more 
> general solution, let's see if it works (hope so!)

I've tried mrobinson's suggestion[*] but couldn't get it working with changes in DRT only: I always needed anyway some timeouts to ensure layout() has been called when asking for the title of the <label> element.

Hence, I'm now attaching a combined patch with Joanmarie's patch + the new test, where I tried to reduce those timeouts to a minimum (while reasonable) value.

Let's see if we can get some review on this then and perhaps some advice to get, if possible, a more general solution (perhaps I was doing something wrong wrt mrobinson's suggestion).

> Once I'm done with this, next step would be bug 30869. Let'see if we can get 
> rid of these two once and for all in a row! :-)

I'll step into this one now, while waiting for review on this combined patch.

[*]  Try to call to webkit_web_frame_layout() before dumping the tree

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.