[Webkit-unassigned] [Bug 40376] [Qt] Sometimes I see pixel dust when the transform is changing rapidly with Qt graphics layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40376


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58555|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>  2010-06-15 01:16:44 PST ---
(From update of attachment 58555)
I don't know about problem, but this patch won't be accepted because it doesn't apply (cq-) and have multiple coding style issues (r-). You can use WebKitTools/Scripts/check-coding-style script to find some coding style problems. 

Actually I should close this bug report as invalid, as it is not possible to reproduce the problem, please provide us a test case :-). Good luck!

> +        No new tests. (OOPS!)
It is possible to add a new autotest?

> +            if (QGraphicsScene *s = scene()) {
'*' is in a wrong place.

> -    m_backingStoreKey = QPixmapCache::insert(pixmap);    
> +    m_backingStoreKey = QPixmapCache::insert(pixmap);
Spaces at the end of the line

> @@ -398,7 +410,10 @@ void GraphicsLayerQtImpl::updateTransform()
>      if (!inverseOk)
>          return;
>  
> -    setTransform(transform2D);
> +        if ( transform2D != transform() ) {
> +                handleGeometryChange();
> +                setTransform(transform2D);
> +        }
Wrong intendation

> @@ -537,20 +552,23 @@ void GraphicsLayerQtImpl::flushChanges(bool recursive, bool forceUpdateTransform
>  
>      if (m_changeMask & SizeChange) {
>          if (m_layer->size() != m_state.size) {
> -            prepareGeometryChange();
> +                        handleGeometryChange();
Wrong indentation

> +#if 0
>      // FIXME: this is a hack, due to a probable QGraphicsScene bug when rapidly modifying the perspective
>      // but without this line we get graphic artifacts
>      if ((m_changeMask & ChildrenTransformChange) && m_state.childrenTransform != m_layer->childrenTransform())
>          if (scene())
>              scene()->update();
> +#endif
If you believe that this code in unneeded you should remove it.

> +        // handleGeometryChange();
It is not a proper comment.

>      if (!recursive)
> -        return;    
> +        return;
Spaces at the end of line.

> -        }        
> +        }
Spaces at the end of line.

> +#if 1
>          // FIXME: this is a hack, due to a probable QGraphicsScene bug.
>          // Without this the opacity change doesn't always have immediate effect.
>          if (m_layer.data()->scene() && !m_layer.data()->opacity() && opacity)
>              m_layer.data()->scene()->update();
> +#endif
#if 1 is not pointless as 1 == true, so this code will be always included.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.