[Webkit-unassigned] [Bug 40606] Fix compilation errors in BlobBuilder with FILE_WRITER enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40606





--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-15 00:20:23 PST ---
Thanks for reviewing; the patch was a bit rough.

(In reply to comment #2)
> (From update of attachment 58743 [details])
> WebCore/ChangeLog:1
>  +  2010-06-14  Kinuko Yasuda  <kinuko at kinuko2-macpro.mtv.corp.google.com>
> The email address needs to be fixed.

Fixed.

> WebCore/ChangeLog:8
>  +          No new tests.
> This should explain why no new tests were added. For example:
> "No functionality change so no new tests."

Fixed.

> WebCore/html/BlobBuilder.h:38
>  +  #include "PlatformString.h"
> WebCore/html/BlobBuilder.h:41
>  +  #include <wtf/text/CString.h>

Both lines weren't necessary.  Removed them and added a forward declaration for String.
(I had needed to include wtf/text/CString.h because I had included PlatformString.h that wasn't really necessary.)

> WebCore/html/BlobBuilder.h: 43
>  +  class ExceptionCode;
> 
> Typically Exception code is defined like this:
>   typedef int ExceptionCode;
> and ExceptionCode.h isn't included. (Also if you add this line, it should come after the class Blob; forward declaration.)

Right, the forward declaration actually didn't work (so I had removed the line and added '#include "BlobBuilder.h"' in the previous patch).

I replaced the line with a typedef.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.