[Webkit-unassigned] [Bug 40280] <meter> should allow styling for each gauge-level and component

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40280


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58632|review?                     |review-
               Flag|                            |




--- Comment #4 from Kent Tamura <tkent at chromium.org>  2010-06-14 19:59:07 PST ---
(From update of attachment 58632)
LayoutTests/ChangeLog:10
 +          - Disabled pixel tests for HTMLMeterElement is temporality disabled.
This sentence looks curious.  Maybe either of "disabled" is not needed?
typo: temporality -> temporarily


LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:13
 +          window.setTimeout(function(evt) {
What's the intention of this setTimeout()?


LayoutTests/platform/qt/Skipped:3289
 +  fast/dom/HTMLMeterElement/meter-element.html
Because Qt has ENABLE_METER_TAG, we don't need to skip the test.  we can:
 - Commit this change
 - Qt buildbot runs
 - Pick the Qt test result
 - Commit it


WebCore/WebCore.xcodeproj/project.pbxproj:21781
 +                  A7AA66D611C5ED6A001D8C8C /* RenderIndicator.cpp in Sources */,
Should be sorted.


WebCore/rendering/RenderMeter.cpp:66
 +      return IntRect(borderLeft() + paddingLeft(), borderTop() + paddingTop(), lround(width() - borderLeft() - paddingLeft() - borderRight() - paddingRight()), height()  - borderTop() - paddingTop() - borderBottom() - paddingBottom());
We should have a test for this.  e.g.
meter {
  border-left-width: 100px;
  border-right-width: 1px;
}
and the meter value is just a half.



WebCore/rendering/RenderTheme.cpp:236
 +  bool RenderTheme::canPaintControlsFor(RenderObject* renderObject) const
Can we merge this into RenderTheme::isControlStyled()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.