[Webkit-unassigned] [Bug 39456] [chromium] WebFrame::contentAsText should not return the text from hidden frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39456





--- Comment #15 from Jay Civelli <jcivelli at chromium.org>  2010-06-14 17:49:30 PST ---
(In reply to comment #13)
> (From update of attachment 58707 [details])
> WebKit/chromium/public/WebCString.h:72
>  +      bool lessThan(const WebCString& other) const;
> needs the WEBKIT_API prefix
> 
> WebKit/chromium/src/WebCString.cpp:44
>  +  bool WebCString::lessThan(const WebCString& other) const
> why not implement 'int compare(other)' instead?  given that you
> are using strncmp, you basically get compare for free.
Done, change to lessThan to compare.

> WebKit/chromium/tests/WebFrameTest.cpp:60
>  +          webkit_support::RegisterMockedURL(url, response, WebString::fromUTF8(filePath.c_str()));
> nit: no need for the .c_str()
Removed.

> WebKit/chromium/tests/WebFrameTest.cpp:77
>  +      response.setMIMEType(WebString::fromUTF8("text/html"));
> nit: you can just type response.setMIMEType("text/html"), and the right thing will happen.
Done.

> WebKit/chromium/tests/WebFrameTest.cpp:82
>  +          WebURL webURL = GURL(rootURL + files[i]);
> we should really have a constructor for WebURL that parses its input.
> that doesn't have to be part of this patch.
More complicated than I thought initially, will have to be done in a subsequent CL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.