[Webkit-unassigned] [Bug 39456] [chromium] WebFrame::contentAsText should not return the text from hidden frames
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 14 16:47:20 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=39456
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #58707|review? |review-
Flag| |
--- Comment #13 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2010-06-14 16:47:19 PST ---
(From update of attachment 58707)
WebKit/chromium/public/WebCString.h:72
+ bool lessThan(const WebCString& other) const;
needs the WEBKIT_API prefix
WebKit/chromium/src/WebCString.cpp:44
+ bool WebCString::lessThan(const WebCString& other) const
why not implement 'int compare(other)' instead? given that you
are using strncmp, you basically get compare for free.
WebKit/chromium/tests/WebFrameTest.cpp:60
+ webkit_support::RegisterMockedURL(url, response, WebString::fromUTF8(filePath.c_str()));
nit: no need for the .c_str()
WebKit/chromium/tests/WebFrameTest.cpp:77
+ response.setMIMEType(WebString::fromUTF8("text/html"));
nit: you can just type response.setMIMEType("text/html"), and the right thing will happen.
WebKit/chromium/tests/WebFrameTest.cpp:82
+ WebURL webURL = GURL(rootURL + files[i]);
we should really have a constructor for WebURL that parses its input.
that doesn't have to be part of this patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list