[Webkit-unassigned] [Bug 37851] [GTK] Does not compile with -DGSEAL_ENABLE
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 14 15:19:49 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=37851
Gustavo Noronha (kov) <gns at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #58689|review? |review+
Flag| |
--- Comment #10 from Gustavo Noronha (kov) <gns at gnome.org> 2010-06-14 15:19:49 PST ---
(From update of attachment 58689)
Looks good to me, with the following comments:
WebKit/gtk/tests/testdomnode.c:164
+ g_assert(webkit_dom_node_has_child_nodes(WEBKIT_DOM_NODE(body)) == FALSE);
oops =)
WebKit/gtk/webkit/webkitwebview.cpp:834
+ gdk_window_set_user_data(gtk_widget_get_window(widget), widget);
Might be worth saving the call to get here by using a variable? Micro-optimization, but it doesn't get less readable.
WebKit/gtk/webkit/webkitwebview.cpp:845
+ gtk_im_context_set_client_window(priv->imContext, gtk_widget_get_window(widget));
One more call saved! yay hehe
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list