[Webkit-unassigned] [Bug 40418] Removes duplication between platform/chromium-win and platform/chromium-mac test expectations by moving files to platform/chromium.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40418





--- Comment #10 from Eric Seidel <eric at webkit.org>  2010-06-14 12:05:24 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> > It should be possible to write a generic version of this script using the classes in webkittools/scripts/webkitpy/layout_test/port /  a generic version of this script 
> > would be HUGELY useful!
> 
> I'm happy to port it over to python, but do you think it's actually going to be used more than once? :) I'm always a bit worried about one-off scripts that get rotten too quickly.
> 
> (oh, and just checking: if I do port to python, I should use things like python's md5 rather than depend on external tools such as fdupes, right?)

We have a bunch of one-off scripts which we have committed to WebKitTools/Scripts and run occasionally.  Most of them are perl, but more and more of our new scripting is moving to python.

I guess I didn't realize this wasn't already python.  It certainly looks like it. :)

I think what you've done is great.  I just would love a script that we can run every 6 months to make sure we don't have duplicate layout test results.  Layout tests are constantly changing, and as the port converge and diverge in their behavior we should be able to easily keep the duplicate result files to a minimum.

An advanced version of such a script could point out that all the ports agree with each other, just that the main expected results should really be mac-only, or some-such.  That's probably a v2 feature though. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.