[Webkit-unassigned] [Bug 40544] [Chromium] Add stubs for OOP font loading to Chromium WebKit API on OSX.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40544


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58590|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-14 11:46:34 PST ---
(From update of attachment 58590)
WebCore/platform/chromium/ChromiumBridge.h:143
 +  #endif
nit: please add a new line after the #endif

WebKit/chromium/src/ChromiumBridge.cpp:410
 +      return ss ? ss->loadFont(srcFont, out) : true;
why return true when there is no sandbox support?  shouldn't you also do |*out = 0;| before returning?

WebCore/platform/chromium/ChromiumBridge.h:50
 +  
nit: no need for this new line here.  it is nice to keep the OS(DARWIN)
block as one contiguous block since it is fairly small.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.